[
https://issues.apache.org/jira/browse/AVRO-3571?focusedWorklogId=788925&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-788925
]
ASF GitHub Bot logged work on AVRO-3571:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jul/22 10:33
Start Date: 08/Jul/22 10:33
Worklog Time Spent: 10m
Work Description: kojiromike commented on code in PR #1756:
URL: https://github.com/apache/avro/pull/1756#discussion_r916689922
##########
lang/py/avro/io.py:
##########
@@ -205,12 +204,11 @@ def _map_iterator(node: ValidationNode) ->
ValidationNodeGeneratorType:
class BinaryDecoder:
"""Read leaf values."""
-
_reader: IO[bytes]
def __init__(self, reader: IO[bytes]) -> None:
"""
- reader is a Python object on which we can call read, seek, and tell.
+ Reader is a Python object on which we can call read, seek, and tell.
Review Comment:
I agree. See my comment below about `writer`.
Issue Time Tracking
-------------------
Worklog Id: (was: 788925)
Time Spent: 1.5h (was: 1h 20m)
> Python code refactor and rearrangement
> --------------------------------------
>
> Key: AVRO-3571
> URL: https://issues.apache.org/jira/browse/AVRO-3571
> Project: Apache Avro
> Issue Type: Improvement
> Components: python
> Reporter: Diptonil Roy
> Priority: Minor
> Labels: beginner, easyfix, newbie, pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The changes made are:
> # Code altered according to PEP 8 conventions. Files changed are: io.py,
> constants.py, schema.py, codecs.py, datafile.py and compatibility.py.
> # General constants INT_MIN_VALUE, INT_MAX_VALUE, LONG_MIN_VALUE &
> LONG_MAX_VALUE shifted from schema.py to constants.py for clarity and better
> organization.
> (This is my first attempt to contribute to any open source project, not only
> this project. If I have made any errors or have misunderstood any step,
> please forgive me. I would be happy to adhere to any suggestions)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
