[
https://issues.apache.org/jira/browse/AVRO-3603?focusedWorklogId=799898&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-799898
]
ASF GitHub Bot logged work on AVRO-3603:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Aug/22 06:56
Start Date: 11/Aug/22 06:56
Worklog Time Spent: 10m
Work Description: KalleOlaviNiemitalo commented on PR #1819:
URL: https://github.com/apache/avro/pull/1819#issuecomment-1211616306
Does this change help users of the library in some way? Better support for
unloadable assemblies perhaps?
The breaking changes are worrisome, but I'm not using Avro.Reflect directly
and
<https://github.com/confluentinc/confluent-kafka-dotnet/tree/v1.9.2/src/Confluent.SchemaRegistry.Serdes.Avro>
doesn't appear to use it either (uses only Avro.Generic and Avro.Specific).
Can the dependency on Microsoft.Extensions.DependencyInjection be replaced
with Microsoft.Extensions.DependencyInjection.Abstractions? For people using
Autofac or other DI libraries.
Can Avro.Reflect be split to a separate NuGet package so that users of
Avro.Generic and Avro.Specific don't need to ship any DI libraries (and audit
compliance with their licenses)?
Issue Time Tracking
-------------------
Worklog Id: (was: 799898)
Time Spent: 1h 20m (was: 1h 10m)
> .NET/#C: Refactor ReflectReader/Writer: rename and refactor caches, add DI
> --------------------------------------------------------------------------
>
> Key: AVRO-3603
> URL: https://issues.apache.org/jira/browse/AVRO-3603
> Project: Apache Avro
> Issue Type: Improvement
> Reporter: Khrystyna Popadyuk
> Assignee: Khrystyna Popadyuk
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Current ReflectReader/Writer use a lot of static entities (classes, methods,
> fields). It is good to refactor them with interfaces and DI approach.
> If do such update at once it requires massive changes and can we difficult to
> review and test.
> This story is created as first step for such refactoring. It will include:
> - group classes by folders
> - add DI
> - rename and refactor ClassCash and EnumCache (avoid method refactoring in
> scope of this story)
> This story do not update method implementation.
> This is breaking changes.
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
