[
https://issues.apache.org/jira/browse/AVRO-3603?focusedWorklogId=799955&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-799955
]
ASF GitHub Bot logged work on AVRO-3603:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Aug/22 11:20
Start Date: 11/Aug/22 11:20
Worklog Time Spent: 10m
Work Description: KalleOlaviNiemitalo commented on PR #1819:
URL: https://github.com/apache/avro/pull/1819#issuecomment-1211856169
> Can Avro.Reflect be split to a separate NuGet package so that users of
Avro.Generic and Avro.Specific don't need to ship any DI libraries (and audit
compliance with their licenses)?
Looking at this PR a bit more,
Avro.Reflect.DependencyInjection.IServiceCollectionExtensions is the only class
that references Microsoft.Extensions.DependencyInjection or IServiceProvider,
and its implementation is rather trivial. The dependency on the DI library
could be avoided by deleting IServiceCollectionExtensions and making class
ReflectCache public like class ClassCache was.
Issue Time Tracking
-------------------
Worklog Id: (was: 799955)
Time Spent: 2h 10m (was: 2h)
> .NET/#C: Refactor ReflectReader/Writer: rename and refactor caches, add DI
> --------------------------------------------------------------------------
>
> Key: AVRO-3603
> URL: https://issues.apache.org/jira/browse/AVRO-3603
> Project: Apache Avro
> Issue Type: Improvement
> Reporter: Khrystyna Popadyuk
> Assignee: Khrystyna Popadyuk
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Current ReflectReader/Writer use a lot of static entities (classes, methods,
> fields). It is good to refactor them with interfaces and DI approach.
> If do such update at once it requires massive changes and can we difficult to
> review and test.
> This story is created as first step for such refactoring. It will include:
> - group classes by folders
> - add DI
> - rename and refactor ClassCash and EnumCache (avoid method refactoring in
> scope of this story)
> This story do not update method implementation.
> This is breaking changes.
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
