[
https://issues.apache.org/jira/browse/AVRO-3603?focusedWorklogId=799910&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-799910
]
ASF GitHub Bot logged work on AVRO-3603:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Aug/22 07:23
Start Date: 11/Aug/22 07:23
Worklog Time Spent: 10m
Work Description: martin-g commented on code in PR #1819:
URL: https://github.com/apache/avro/pull/1819#discussion_r943168006
##########
lang/csharp/src/apache/main/Reflect/EnumCache.cs:
##########
@@ -1,57 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * https://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-using System;
-using System.Collections.Concurrent;
-using Avro;
-
-namespace Avro.Reflect
-{
- /// <summary>
- /// Cache of enum types. Cache key is the schema fullname.
- /// </summary>
- public static class EnumCache
Review Comment:
Is it possible to keep the class for a while as deprecated ?
##########
lang/csharp/src/apache/main/Reflect/Converter/DateTimeOffsetToLongConverter.cs:
##########
@@ -17,8 +17,9 @@
*/
using System;
+using Avro.Reflect.Interface;
-namespace Avro.Reflect
+namespace Avro.Reflect.Conver
Review Comment:
missing `er` ?!
##########
lang/csharp/src/apache/main/Reflect/Reflection/DotnetClass.cs:
##########
@@ -20,8 +20,9 @@
using System.Reflection;
using System.Collections.Concurrent;
using Avro;
+using Avro.Reflect.Interface;
-namespace Avro.Reflect
+namespace Avro.Reflect.Reflection
Review Comment:
Why there are two `reflect***` packages/namespaces here ?
Issue Time Tracking
-------------------
Worklog Id: (was: 799910)
Time Spent: 1h 40m (was: 1.5h)
> .NET/#C: Refactor ReflectReader/Writer: rename and refactor caches, add DI
> --------------------------------------------------------------------------
>
> Key: AVRO-3603
> URL: https://issues.apache.org/jira/browse/AVRO-3603
> Project: Apache Avro
> Issue Type: Improvement
> Reporter: Khrystyna Popadyuk
> Assignee: Khrystyna Popadyuk
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Current ReflectReader/Writer use a lot of static entities (classes, methods,
> fields). It is good to refactor them with interfaces and DI approach.
> If do such update at once it requires massive changes and can we difficult to
> review and test.
> This story is created as first step for such refactoring. It will include:
> - group classes by folders
> - add DI
> - rename and refactor ClassCash and EnumCache (avoid method refactoring in
> scope of this story)
> This story do not update method implementation.
> This is breaking changes.
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
