FYI: JB's PR https://github.com/apache/beam/pull/4424 has been merged, and now it's a free-for-all in terms of upgrading code to Java8!
(A bunch of other items on https://issues.apache.org/jira/browse/BEAM-3426 still remain) On Tue, Jan 16, 2018 at 12:28 PM Eugene Kirpichov <kirpic...@google.com> wrote: > Thanks. I think the one changing build is higher priority because it > enables people to start modernizing the code (e.g. FileIO) and it'd be good > to do that before 2.3 cut. I wasn't able to find the PR you mentioned in > https://github.com/apache/beam/pulls , which one is it? > > On Mon, Jan 15, 2018 at 10:41 PM Jean-Baptiste Onofré <j...@nanthrax.net> > wrote: > >> Hi >> >> I created the PR about build during the weekend. I'm working on the >> examples merge PR and also polishing the first one. I will add you as >> reviewer. >> >> Regards >> JB >> Le 16 janv. 2018, à 07:35, Eugene Kirpichov <kirpic...@google.com> a >> écrit: >>> >>> Hi JB - any updates here? >>> >>> On Tue, Jan 9, 2018, 2:51 AM Jean-Baptiste Onofré < j...@nanthrax.net> >>> wrote: >>> >>>> Actually, it's part of the build and I will "expand" the java version >>>> in the >>>> enforcer. >>>> >>>> Regards >>>> JB >>>> >>>> On 01/09/2018 11:46 AM, Etienne Chauchot wrote: >>>> > Hi, >>>> > >>>> > +1 as well, excellent news ! >>>> > >>>> > I would add also: remove (AFAIK in some IOs) the enforcer >>>> configuration (like >>>> > [1]) that were put when java 8 was needed in a java 7 build. >>>> > >>>> > [1] >>>> > >>>> > <requireJavaVersion> >>>> > <version>[1.8,)</version> >>>> > </requireJavaVersion> >>>> > >>>> > >>>> > Etienne >>>> > >>>> > >>>> > Le 08/01/2018 à 14:02, Jean-Baptiste Onofré a écrit : >>>> >> I created https://issues.apache.org/jira/browse/BEAM-3426 as >>>> umbrella Jira and >>>> >> created the sub-tasks related to build and examples. >>>> >> >>>> >> Feel free to add the relevant sub-tasks there. >>>> >> >>>> >> Regards >>>> >> JB >>>> >> >>>> >> On 01/08/2018 11:33 AM, Ismaël Mejía wrote: >>>> >>> Excellent news ! Probably a good idea to fill JIRAs to all of >>>> those. I >>>> >>> would add: >>>> >>> >>>> >>> - Remove the references in the website to Java 7 >>>> >>> - Remove Java 7 and any related task from the CI >>>> >>> - Update the docker dev build images (I will take this one since >>>> >>> reproducible build is my pet project) >>>> >>> - Upgrade the IOs who were still in older versions because of >>>> client >>>> >>> compatibility. I remember SolfIO was one case but probably there >>>> are >>>> >>> others. >>>> >>> >>>> >>> >>>> >>> On Mon, Jan 8, 2018 at 7:49 AM, Jean-Baptiste Onofré < >>>> j...@nanthrax.net> wrote: >>>> >>>> Yes, that's the plan: build first, example "merge" after. >>>> >>>> >>>> >>>> Regards >>>> >>>> JB >>>> >>>> >>>> >>>> On 01/08/2018 07:43 AM, Eugene Kirpichov wrote: >>>> >>>>> >>>> >>>>> Sounds great, thanks! Probably best done as 2 separate steps, >>>> because >>>> >>>>> after updating the build scripts, everything else can begin in >>>> parallel? >>>> >>>>> >>>> >>>>> On Sun, Jan 7, 2018 at 10:38 PM Jean-Baptiste Onofré < >>>> j...@nanthrax.net >>>> >>>>> <mailto: j...@nanthrax.net>> wrote: >>>> >>>>> >>>> >>>>> Hi Eugene, >>>> >>>>> >>>> >>>>> I'm taking the build update: Maven/Gradle with enforcer + >>>> merge of the >>>> >>>>> examples >>>> >>>>> all together. >>>> >>>>> >>>> >>>>> Regards >>>> >>>>> JB >>>> >>>>> >>>> >>>>> On 01/08/2018 07:34 AM, Eugene Kirpichov wrote: >>>> >>>>> > The vote on user@ about switching to Java 8 has >>>> concluded, >>>> >>>>> affirmatively. >>>> >>>>> > >>>> >>>>> > What needs to be done to complete the switch? I can see >>>> at least >>>> >>>>> the >>>> >>>>> following: >>>> >>>>> > - Change maven and gradle scripts to use 1.8 source and >>>> target >>>> >>>>> version >>>> >>>>> > - Fix resulting compilation/test errors (Java8 has >>>> slightly >>>> >>>>> different type >>>> >>>>> > checking, more minor issues may arise) >>>> >>>>> > - Remove all special-casing of java8 in build scripts >>>> >>>>> > - Merge all modules like "java8 examples" and "java8 >>>> tests" into >>>> >>>>> respective >>>> >>>>> > non-"java8" modules >>>> >>>>> > - Organize an effort to modernize code to use Java 8 >>>> constructs >>>> >>>>> where >>>> >>>>> > appropriate. Especially important to modernize examples. >>>> To a large >>>> >>>>> extent this >>>> >>>>> > can probably be automated with an IDE. >>>> >>>>> > >>>> >>>>> > Anything else? >>>> >>>>> > >>>> >>>>> >>>> >>>>> -- >>>> >>>>> Jean-Baptiste Onofré >>>> >>>>> jbono...@apache.org <mailto: jbono...@apache.org> >>>> >>>>> http://blog.nanthrax.net >>>> >>>>> Talend - http://www.talend.com >>>> >>>>> >>>> >>>> >>>> >>>> -- >>>> >>>> Jean-Baptiste Onofré >>>> >>>> jbono...@apache.org >>>> >>>> http://blog.nanthrax.net >>>> >>>> Talend - http://www.talend.com >>>> >> >>>> > >>>> >>>> -- >>>> Jean-Baptiste Onofré >>>> jbono...@apache.org >>>> http://blog.nanthrax.net >>>> Talend - http://www.talend.com >>>> >>>
