Hi Romain,

Good point. However, AFAIR, AutoValue supports Java 8 (not Java 8 "style" but it compiles without problem using Java 8).

Regards
JB

On 01/08/2018 11:36 AM, Romain Manni-Bucau wrote:
+1000

also requires to upgrade @Auto* processor which was not supporting j8 in current (beam dependency) version.


Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau>

2018-01-08 11:33 GMT+01:00 Ismaël Mejía <ieme...@gmail.com <mailto:ieme...@gmail.com>>:

    Excellent news ! Probably a good idea to fill JIRAs to all of those. I
    would add:

    - Remove the references in the website to Java 7
    - Remove Java 7 and any related task from the CI
    - Update the docker dev build images (I will take this one since
    reproducible build is my pet project)
    - Upgrade the IOs who were still in older versions because of client
    compatibility. I remember SolfIO was one case but probably there are
    others.


    On Mon, Jan 8, 2018 at 7:49 AM, Jean-Baptiste Onofré <j...@nanthrax.net
    <mailto:j...@nanthrax.net>> wrote:
     > Yes, that's the plan: build first, example "merge" after.
     >
     > Regards
     > JB
     >
     > On 01/08/2018 07:43 AM, Eugene Kirpichov wrote:
     >>
     >> Sounds great, thanks! Probably best done as 2 separate steps, because
     >> after updating the build scripts, everything else can begin in parallel?
     >>
     >> On Sun, Jan 7, 2018 at 10:38 PM Jean-Baptiste Onofré <j...@nanthrax.net
    <mailto:j...@nanthrax.net>
     >> <mailto:j...@nanthrax.net <mailto:j...@nanthrax.net>>> wrote:
     >>
     >>     Hi Eugene,
     >>
     >>     I'm taking the build update: Maven/Gradle with enforcer + merge of 
the
     >> examples
     >>     all together.
     >>
     >>     Regards
     >>     JB
     >>
     >>     On 01/08/2018 07:34 AM, Eugene Kirpichov wrote:
     >>      > The vote on user@ about switching to Java 8 has concluded,
     >> affirmatively.
     >>      >
     >>      > What needs to be done to complete the switch? I can see at least
     >> the
     >>     following:
     >>      > - Change maven and gradle scripts to use 1.8 source and target
     >> version
     >>      > - Fix resulting compilation/test errors (Java8 has slightly
     >> different type
     >>      > checking, more minor issues may arise)
     >>      > - Remove all special-casing of java8 in build scripts
     >>      > - Merge all modules like "java8 examples" and "java8 tests" into
     >> respective
     >>      > non-"java8" modules
     >>      > - Organize an effort to modernize code to use Java 8 constructs
     >> where
     >>      > appropriate. Especially important to modernize examples. To a 
large
     >>     extent this
     >>      > can probably be automated with an IDE.
     >>      >
     >>      > Anything else?
     >>      >
     >>
     >>     --
     >>     Jean-Baptiste Onofré
     >> jbono...@apache.org <mailto:jbono...@apache.org>
    <mailto:jbono...@apache.org <mailto:jbono...@apache.org>>
     >> http://blog.nanthrax.net
     >>     Talend - http://www.talend.com
     >>
     >
     > --
     > Jean-Baptiste Onofré
     > jbono...@apache.org <mailto:jbono...@apache.org>
     > http://blog.nanthrax.net
     > Talend - http://www.talend.com



--
Jean-Baptiste Onofré
jbono...@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com

Reply via email to