+1 (best commits are the once that remove code :-) _/ _/ Alex Van Boxel
On Wed, May 15, 2019 at 2:04 PM Manu Zhang <owenzhang1...@gmail.com> wrote: > +1 > > On Wed, May 15, 2019 at 7:57 PM Maximilian Michels <m...@apache.org> wrote: > >> +1 >> >> On 15.05.19 13:19, Robert Bradshaw wrote: >> > +1 for removing the code given the current state of things. >> > >> > On Wed, May 15, 2019 at 12:32 AM Ruoyun Huang <ruo...@google.com> >> wrote: >> >> >> >> +1 >> >> >> >> From: Daniel Oliveira <danolive...@google.com> >> >> Date: Tue, May 14, 2019 at 2:19 PM >> >> To: dev >> >> >> >>> Hello everyone, >> >>> >> >>> I'm calling for a vote on removing the deprecated Java Reference >> Runner code. The PR for the change has already been tested and reviewed: >> https://github.com/apache/beam/pull/8380 >> >>> >> >>> [ ] +1, Approve merging the removal PR in it's current state >> >>> [ ] -1, Veto the removal PR (please provide specific comments) >> >>> >> >>> The vote will be open for at least 72 hours. Since this a vote on >> code-modification, it is adopted if there are at least 3 PMC affirmative >> votes and no vetoes. >> >>> >> >>> For those who would like context on why the Java Reference Runner is >> being deprecated, the discussions took place in the following email threads: >> >>> >> >>> (8 Feb. 2019) Thoughts on a reference runner to invest in? - Decision >> to deprecate the Java Reference Runner and use the Python FnApiRunner for >> those use cases instead. >> >>> (14 Mar. 2019) Python PVR Reference post-commit tests failing - >> Removal of Reference Runner Post-Commits from Jenkins, and discussion on >> removal of code. >> >>> (25 Apr. 2019) Removing Java Reference Runner code - Discussion >> thread before this formal vote. >> >> >> >> >> >> >> >> -- >> >> ================ >> >> Ruoyun Huang >> >> >> >
