Pablo has merged the PR in and assigned a tag to the commit to make the ULR code easy to find in the future (java-ulr-removal <https://github.com/apache/beam/tree/java-ulr-removal>). The Java ULR is officially removed!
On Fri, May 17, 2019 at 4:59 PM Daniel Oliveira <danolive...@google.com> wrote: > It's been 72 hours and this vote has passed. > > There are 10 approving votes, 5 of which are binding: > * Lukasz Cwik > * Ahmet Altay > * Pablo Estrada > * Robert Bradshaw > * Maximilian Michels > > There are no disapproving votes. > > With that decided, I'll get someone to merge the change on Monday (I'm > hesitant to do a big merge right before a weekend). > > *From: *Michael Luckey <adude3...@gmail.com> > *Date: *Wed, May 15, 2019 at 5:26 AM > *To: * <dev@beam.apache.org> > > +1 >> >> On Wed, May 15, 2019 at 2:17 PM Alex Van Boxel <a...@vanboxel.be> wrote: >> >>> +1 >>> >>> (best commits are the once that remove code :-) >>> _/ >>> _/ Alex Van Boxel >>> >>> >>> On Wed, May 15, 2019 at 2:04 PM Manu Zhang <owenzhang1...@gmail.com> >>> wrote: >>> >>>> +1 >>>> >>>> On Wed, May 15, 2019 at 7:57 PM Maximilian Michels <m...@apache.org> >>>> wrote: >>>> >>>>> +1 >>>>> >>>>> On 15.05.19 13:19, Robert Bradshaw wrote: >>>>> > +1 for removing the code given the current state of things. >>>>> > >>>>> > On Wed, May 15, 2019 at 12:32 AM Ruoyun Huang <ruo...@google.com> >>>>> wrote: >>>>> >> >>>>> >> +1 >>>>> >> >>>>> >> From: Daniel Oliveira <danolive...@google.com> >>>>> >> Date: Tue, May 14, 2019 at 2:19 PM >>>>> >> To: dev >>>>> >> >>>>> >>> Hello everyone, >>>>> >>> >>>>> >>> I'm calling for a vote on removing the deprecated Java Reference >>>>> Runner code. The PR for the change has already been tested and reviewed: >>>>> https://github.com/apache/beam/pull/8380 >>>>> >>> >>>>> >>> [ ] +1, Approve merging the removal PR in it's current state >>>>> >>> [ ] -1, Veto the removal PR (please provide specific comments) >>>>> >>> >>>>> >>> The vote will be open for at least 72 hours. Since this a vote on >>>>> code-modification, it is adopted if there are at least 3 PMC affirmative >>>>> votes and no vetoes. >>>>> >>> >>>>> >>> For those who would like context on why the Java Reference Runner >>>>> is being deprecated, the discussions took place in the following email >>>>> threads: >>>>> >>> >>>>> >>> (8 Feb. 2019) Thoughts on a reference runner to invest in? - >>>>> Decision to deprecate the Java Reference Runner and use the Python >>>>> FnApiRunner for those use cases instead. >>>>> >>> (14 Mar. 2019) Python PVR Reference post-commit tests failing - >>>>> Removal of Reference Runner Post-Commits from Jenkins, and discussion on >>>>> removal of code. >>>>> >>> (25 Apr. 2019) Removing Java Reference Runner code - Discussion >>>>> thread before this formal vote. >>>>> >> >>>>> >> >>>>> >> >>>>> >> -- >>>>> >> ================ >>>>> >> Ruoyun Huang >>>>> >> >>>>> >>>>
