+1 (non-binding)
Validated my downstream dependencies build fine against the RC.
On 8/23/21 11:48 PM, Valentyn Tymofieiev wrote:
+1, ran several Python batch and streaming pipelines from quickstarts
and examples without issues and checked Dataflow containers for
dependency compatibility.
On Mon, Aug 23, 2021 at 2:41 PM Robert Bradshaw <[email protected]
<mailto:[email protected]>> wrote:
+1 (binding). The artifacts and signatures look good to me.
On Mon, Aug 23, 2021 at 1:24 PM Chamikara Jayalath
<[email protected] <mailto:[email protected]>> wrote:
>
> +1 (binding)
>
> Thanks,
> Cham
>
> On Mon, Aug 23, 2021 at 11:17 AM Ankur Goenka <[email protected]
<mailto:[email protected]>> wrote:
>>
>> Thanks for the validations.
>>
>> As for the errors. Externally built containers were not pulled
internally. The error should be fixed now.
>>
>> On Mon, Aug 23, 2021 at 7:04 AM Chamikara Jayalath
<[email protected] <mailto:[email protected]>> wrote:
>>>
>>> Are Dataflow containers not available yet ?
>>>
>>> I'm getting following when running some verifications.
>>>
>>> [failed to "StartContainer" for "sdk-0-0" with
ImagePullBackOff: "Back-off pulling image
\"gcr.io/cloud-dataflow/v1beta3/beam_java11_sdk:2.32.0\
<http://gcr.io/cloud-dataflow/v1beta3/beam_java11_sdk:2.32.0%5C>"",
failed to "StartContainer" for "sdk-2-0" with ImagePullBackOff:
"Back-off pulling image
\"gcr.io/cloud-dataflow/v1beta3/beam_java11_sdk:2.32.0\
<http://gcr.io/cloud-dataflow/v1beta3/beam_java11_sdk:2.32.0%5C>""
>>>
>>>
>>>
>>> On Sat, Aug 21, 2021 at 7:53 PM Pablo Estrada
<[email protected] <mailto:[email protected]>> wrote:
>>>>
>>>> +1
>>>> I validated by building and running basic unit tests on
existing Dataflow templates.
>>>> Best
>>>> -P.
>>>>
>>>> On Fri, Aug 20, 2021 at 6:52 PM Ahmet Altay <[email protected]
<mailto:[email protected]>> wrote:
>>>>>
>>>>> +1 on the RC. I validated python quick start examples on
direct runners. Thank you Ankur for preparing this.
>>>>>
>>>>> I understand if we need to start a new RC for the open
issues, but I wanted to start the validation as much as possible.
>>>>>
>>>>> Ahmet
>>>>>
>>>>> On Fri, Aug 20, 2021 at 5:45 PM Ahmet Altay
<[email protected] <mailto:[email protected]>> wrote:
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Fri, Aug 20, 2021 at 1:19 PM Alexey Romanenko
<[email protected] <mailto:[email protected]>> wrote:
>>>>>>>
>>>>>>> Yes, you are right, Ahmet.
>>>>>>>
>>>>>>> Though, I just wanted to confirm if the current open P0
issues were introduced after "release-2.32.0" branch cut and we
don’t have any regressions.
>>>>>>
>>>>>>
>>>>>> Good point. I looked at the currently open P0s, there are 4
four:
>>>>>>
>>>>>> https://issues.apache.org/jira/browse/BEAM-12683
<https://issues.apache.org/jira/browse/BEAM-12683> and
https://issues.apache.org/jira/browse/BEAM-12733
<https://issues.apache.org/jira/browse/BEAM-12733> - These are
flakiness issues in integration tests. Same tests existed for
2.32.0. I do not think it is worth cherry picking the fix in RC1.
If there will be a RC2, we can choose to cherry pick
https://github.com/apache/beam/pull/15330
<https://github.com/apache/beam/pull/15330>
>>>>>> https://issues.apache.org/jira/browse/BEAM-12764
<https://issues.apache.org/jira/browse/BEAM-12764> - This was
introduced after release-2.32.0 in
https://github.com/apache/beam/pull/15165
<https://github.com/apache/beam/pull/15165>. We can ignore this
for 2.32.0 release.
>>>>>> https://issues.apache.org/jira/browse/BEAM-12766
<https://issues.apache.org/jira/browse/BEAM-12766> - this is
another flaky integration test, and IIUC it got more flaky after
release-2.32.0 (after https://github.com/apache/beam/pull/14859
<https://github.com/apache/beam/pull/14859>). This is probably
also not worth fixing for 2.32.0
>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On 20 Aug 2021, at 18:26, Ahmet Altay <[email protected]
<mailto:[email protected]>> wrote:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Fri, Aug 20, 2021 at 8:14 AM Alexey Romanenko
<[email protected] <mailto:[email protected]>> wrote:
>>>>>>>>
>>>>>>>> Thanks, Ankur!
>>>>>>>>
>>>>>>>> There are several P0 opened issues. They don’t affect
this release?
>>>>>>>
>>>>>>>
>>>>>>> I do not see any P0 open issues marked for 2.32.0 release
[1]. Am I missing something? Perhaps you are looking at the 2.33.0
release?
>>>>>>>
>>>>>>> [1]
https://issues.apache.org/jira/issues/?jql=project%20%3D%20BEAM%20AND%20status%20in%20(Open%2C%20%22Triage%20Needed%22)%20AND%20resolution%20%3D%20Unresolved%20AND%20fixVersion%20%3D%202.32.0%20ORDER%20BY%20created%20DESC%2C%20priority%20DESC
<https://issues.apache.org/jira/issues/?jql=project%20%3D%20BEAM%20AND%20status%20in%20(Open%2C%20%22Triage%20Needed%22)%20AND%20resolution%20%3D%20Unresolved%20AND%20fixVersion%20%3D%202.32.0%20ORDER%20BY%20created%20DESC%2C%20priority%20DESC>
>>>>>>>
>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> On 20 Aug 2021, at 06:49, Ankur Goenka <[email protected]
<mailto:[email protected]>> wrote:
>>>>>>>>
>>>>>>>> Hi everyone,
>>>>>>>> Please review and vote on the release candidate #1 for
the version 2.32.0, as follows:
>>>>>>>> [ ] +1, Approve the release
>>>>>>>> [ ] -1, Do not approve the release (please provide
specific comments)
>>>>>>>>
>>>>>>>>
>>>>>>>> Reviewers are encouraged to test their own use cases with
the release candidate, and vote +1 if
>>>>>>>> no issues are found.
>>>>>>>>
>>>>>>>> The complete staging area is available for your review,
which includes:
>>>>>>>> * JIRA release notes [1],
>>>>>>>> * the official Apache source release to be deployed to
dist.apache.org <http://dist.apache.org> [2], which is signed with
the key with fingerprint A6699985948 [3],
>>>>>>>> * all artifacts to be deployed to the Maven Central
Repository [4],
>>>>>>>> * source code tag "v2.32.0-RC1" [5],
>>>>>>>> * website pull request listing the release [6],
publishing the API reference manual [7], and the blog post [8].
>>>>>>>> * Java artifacts were built with Maven Gradle 6.8.3 and
OpenJDK/Oracle JDK 1.8.0_181.
>>>>>>>> * Python artifacts are deployed along with the source
release to the dist.apache.org <http://dist.apache.org> [2].
>>>>>>>> * Validation sheet with a tab for 2.32.0 release to help
with validation [9].
>>>>>>>> * Docker images published to Docker Hub [10].
>>>>>>>>
>>>>>>>> The vote will be open for at least 72 hours. It is
adopted by majority approval, with at least 3 PMC affirmative votes.
>>>>>>>>
>>>>>>>> For guidelines on how to try the release in your
projects, check out our blog post at
https://beam.apache.org/blog/validate-beam-release/
<https://beam.apache.org/blog/validate-beam-release/>.
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> Release Manager
>>>>>>>>
>>>>>>>> [1]
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12319527&version=12349992
<https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12319527&version=12349992>
>>>>>>>> [2] https://dist.apache.org/repos/dist/dev/beam/2.32.0/
<https://dist.apache.org/repos/dist/dev/beam/2.32.0/>
>>>>>>>> [3] https://dist.apache.org/repos/dist/release/beam/KEYS
<https://dist.apache.org/repos/dist/release/beam/KEYS>
>>>>>>>> [4]
https://repository.apache.org/content/repositories/orgapachebeam-1223/
<https://repository.apache.org/content/repositories/orgapachebeam-1223/>
>>>>>>>> [5] https://github.com/apache/beam/tree/v2.32.0-RC1
<https://github.com/apache/beam/tree/v2.32.0-RC1>
>>>>>>>> [6] https://github.com/apache/beam/pull/15317
<https://github.com/apache/beam/pull/15317>
>>>>>>>> [7] https://github.com/apache/beam-site/pull/618
<https://github.com/apache/beam-site/pull/618>
>>>>>>>> [8] https://github.com/apache/beam/pull/15324
<https://github.com/apache/beam/pull/15324>
>>>>>>>> [9]
https://docs.google.com/spreadsheets/d/1qk-N5vjXvbcEk68GjbkSZTR8AGqyNUM-oLFo_ZXBpJw/edit#gid=1747256107
<https://docs.google.com/spreadsheets/d/1qk-N5vjXvbcEk68GjbkSZTR8AGqyNUM-oLFo_ZXBpJw/edit#gid=1747256107>
>>>>>>>> [10]
https://hub.docker.com/search?q=apache%2Fbeam&type=image
<https://hub.docker.com/search?q=apache%2Fbeam&type=image>
>>>>>>>>
>>>>>>>>
>>>>>>>
