Screw gerrit, we've already got the Jenkins Enterprise GitHub pull request builder plugin enabled on builds.apache.org - it needs some validation still and hooks to be set up by Infra on the GitHub repos, but once that's done, you can have a job that watches for pull requests, builds them, and comments on the pull request with the build results.
As to that script - how is it being run? I assume by hand by Spark committers? A. On Mon, Jun 30, 2014 at 1:30 PM, Jay Vyas <[email protected]> wrote: > push the merge button…… Almost - but not quite ! > > Sorry for the lack of clarity --- as i recently learned of this process. > I've gotten up to speed on the details: Here they are: > > I'll walk through the way this script > https://github.com/apache/spark/blob/master/dev/merge_spark_pr.py > is used….. > > > 1) Rather than actually submitting a patch, the user submits a pull request > and a branch is created > by the commiter, automatically using the script: > run_cmd("git fetch %s pull/%s/head:%s" % (PR_REMOTE_NAME, pr_num, > pr_branch_name)) > > 2) Then, the script checks via github api if the patch is mergeable. > > pr = get_json("%s/pulls/%s" % (GITHUB_API_BASE, pr_num)) > > 3) Then, the pull request is merged and pushed to apache: > merge_hash = merge_pr(pr_num, target_ref) > >
