On Mon, Jun 30, 2014 at 10:08 PM, Jay Vyas <[email protected]> wrote:
> The actual script is done by the commiters. You can read about the process
> in the spark commiter guidelines:
>
> https://cwiki.apache.org/confluence/display/SPARK/Wiki+Homepage
This makes sense now.
> So the steps would be
>
> 1) Adopt the script for processing pull requests
>
> 2) Add it to our bigtop repo
>
> 3) Create a pull request and test the script for comitting it.
>
> Some might dispute one issue here : The patch system record of is a little
> diluted.
>
> Is that a big deal? Im not sure . I think its a tough decision - its no
> simple answer.
> If losing track of patches builds a significantly more vibrant ecosystem, i
> think its an okay tradeoff.
>
> Any other opinions on this?
Well, whatever automation we create to make the patch validation
and acceptance experience smoother is great.
That said, personally, I'd like to maintain two constraints:
1. all non-trivial changes MUST have a JIRA ID associated with them
2. any fixed for JIRAs that go into our code-base MUST have a
patch attached to a JIRA and be explicitly reviewed and +1ed.
Does this sounds reasonable?
Thanks,
Roman.
