[
https://issues.apache.org/jira/browse/BIGTOP-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14274031#comment-14274031
]
Konstantin Boudnik commented on BIGTOP-1579:
--------------------------------------------
Thanks Olaf. A couple of things:
- in packages.gradle the following bit is missing in the {{else}} branch. Shall
it be kept?
{code}
copy {
from 'LICENSE'
into TAR_DIR
}
{code}
- named variable for closure parameter is normally sits on the same line as the
closure name, e.g. not
{code}
specFile.eachLine {
line ->
{code} but
{code}
specFile.eachLine { line ->
{code}
There are multiple occasions where this is broken. Let's keep the same style as
in the rest of the code.
- there are some formatting issues in lines 421-440. Please fix them
- can we avoid adding .diff files into the source just for the testing
purposes? E.g. {{patch0-getCount2getLength.diff}}. You might need it to test
the functionality, but IMO it shouldn't be sitting there permanently as it
isn't required to build Pig packages
- I think it'd be great to document the patching process somewhere. Perhaps in
the README.md?
- it seems that {{specTmpFileName}} can be avoided all together: you just can
directly dump the content to {{specFileName}}, no?
> Improve Bigtop Toolchain : Create diff files
> --------------------------------------------
>
> Key: BIGTOP-1579
> URL: https://issues.apache.org/jira/browse/BIGTOP-1579
> Project: Bigtop
> Issue Type: Bug
> Components: build
> Reporter: Olaf Flebbe
> Assignee: Olaf Flebbe
> Fix For: 0.9.0
>
> Attachments:
> 0001-BIGTOP-1588-BIGTOP-1579-Implement-patching-for-Bigto.patch,
> 0001-BIGTOP-1588-BIGTOP-1579-Implement-patching-for-Bigto.patch
>
>
> Right now, we apply changes/patches in the do-build-component script in the
> bigtop-packages/common/<package> part of the build process .
> Would be cleaner and easier to use the RPM / Deb functionality of RPMbuild /
> debuild to apply patches. But right now the gradle script is not flexible
> enough. Since make is now obsolete we can improve this situation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
