[ 
https://issues.apache.org/jira/browse/BIGTOP-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14275810#comment-14275810
 ] 

Konstantin Boudnik commented on BIGTOP-1579:
--------------------------------------------

I see one more instance where named closure parameter is sitting on a separate 
line
{code}
      patches.each {
        f -> def res = new File("$DEB_BLD_DIR/debian/$f").renameTo( 
"$DEB_BLD_DIR/debian/patches/$f")
{code}
And could you please answer my question about a need to include 
{{getCount2getLength.diff}} into this patch? it seems to be a separate issue 
fixing Pig build, rather than doing anything about package patching.

> Improve Bigtop Toolchain : Create diff files
> --------------------------------------------
>
>                 Key: BIGTOP-1579
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-1579
>             Project: Bigtop
>          Issue Type: Bug
>          Components: build
>            Reporter: Olaf Flebbe
>            Assignee: Olaf Flebbe
>             Fix For: 0.9.0
>
>         Attachments: 
> 0001-BIGTOP-1588-BIGTOP-1579-Implement-patching-for-Bigto.patch, 
> 0001-BIGTOP-1588-BIGTOP-1579-Implement-patching-for-Bigto.patch, 
> 0002-BIGTOP-1588-BIGTOP-1579-Implement-patching-for-Bigto.patch
>
>
> Right now, we apply changes/patches in the do-build-component script in the 
> bigtop-packages/common/<package> part of the build process .
> Would be cleaner and easier to use the RPM / Deb functionality of RPMbuild / 
> debuild to apply patches. But right now the gradle script is not flexible 
> enough. Since make is now obsolete we can improve this situation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to