[ 
https://issues.apache.org/jira/browse/BIGTOP-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14275441#comment-14275441
 ] 

Olaf Flebbe commented on BIGTOP-1579:
-------------------------------------

Source formatting: Holy $hit ! Sorry, that mess TAB vs Whitespace was not 
intended. Cleaning up.

Regarding {{specTmpFileName}}: I do not think I can directly dump on the 
specfile: Opening with {{newWriter()}} will empy the file before {{eachLine}} 
can pickup the contents of the file itself.

I found that there is a bug in the original script hidden 
{{code}}
          def TOP_LEVEL_DIR = unpacked.list()[0]
-          fileTree ("$TAR_DIR/$TOP_LEVEL_DIR") {
-            include '**/*'
-          }.copy { into TAR_DIR }
-          delete(TOP_LEVEL_DIR)
{{code}}

The upstream download for hue 3.7 contains a broken symbolic link. the gradle 
task dies while trying to copy this link.
I changed it into renaming the individual files, rather copy and deleting it 
afterwards.



> Improve Bigtop Toolchain : Create diff files
> --------------------------------------------
>
>                 Key: BIGTOP-1579
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-1579
>             Project: Bigtop
>          Issue Type: Bug
>          Components: build
>            Reporter: Olaf Flebbe
>            Assignee: Olaf Flebbe
>             Fix For: 0.9.0
>
>         Attachments: 
> 0001-BIGTOP-1588-BIGTOP-1579-Implement-patching-for-Bigto.patch, 
> 0001-BIGTOP-1588-BIGTOP-1579-Implement-patching-for-Bigto.patch
>
>
> Right now, we apply changes/patches in the do-build-component script in the 
> bigtop-packages/common/<package> part of the build process .
> Would be cleaner and easier to use the RPM / Deb functionality of RPMbuild / 
> debuild to apply patches. But right now the gradle script is not flexible 
> enough. Since make is now obsolete we can improve this situation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to