[ 
https://issues.apache.org/jira/browse/BIGTOP-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14370229#comment-14370229
 ] 

Konstantin Boudnik commented on BIGTOP-1689:
--------------------------------------------

bq. Even better: Since upstream is a sister project, we should simply request 
clarification on duplicate option support and possibly have the configuration 
parser changed to fail on duplicate options.
We have Hadoop committers on this project, but there is a couple of thing to 
consider here:
a. Changes in the {{o.a.h.Configuration}} we need might not be considered 
backward compatible, hence it won't get merged into the ongoing 2.x release 
until 3.0. Translation: too long
b. Even if accepted, it might not get on train until 2.9 anyway. And Hadoop 
isn't the only project that might have a similar semantics on configuration. 
So, just fixing it in one place won't necessary solve the problem universally.

> puppet: Allow merging arbitrary site configuration
> --------------------------------------------------
>
>                 Key: BIGTOP-1689
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-1689
>             Project: Bigtop
>          Issue Type: Improvement
>          Components: deployment
>    Affects Versions: 0.8.0
>            Reporter: Peter Slawski
>            Assignee: Peter Slawski
>             Fix For: 1.0.0
>
>         Attachments: BIGTOP-1689.1.patch
>
>
> Puppet should be flexible in allowing arbitrary configuration name value 
> pairs to be merged into a given site.xml file that was generated from a 
> template.
> For example, the following could be included in site.yaml which would add a 
> configuration entry for hadoop.tmp.dir in core-site.xml:
> {code}
> hadoop::common_hdfs::hadoop_core_site_overrides:
>   "hadoop.tmp.dir": "/mnt/var/lib/hadoop/tmp"
> {code}
> This could be implemented as a puppet custom-function taking in the output of 
> template:
> {code}
>     file {
>       "/etc/hadoop/conf/core-site.xml":
>         content => merge_site(template('hadoop/core-site.xml'),  
> $hadoop_core_site_overrides)
>         require => [Package["hadoop"]],
>     }
> {code}
> Perhaps another approach would be to have site.xml templates be created from 
> a single map of name value pairs. The merge would happen before the file 
> content is generated from the template.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to