[
https://issues.apache.org/jira/browse/BIGTOP-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14376562#comment-14376562
]
Peter Slawski commented on BIGTOP-1689:
---------------------------------------
I started working on the program in Groovy over the weekend. I definitely can
see the benefits and will stick to it. I would like to organize classes into
separate files and include unit tests. So, a single Groovy file doesn't scale
well for this kind of program.
Are you referring to [BIGTOP-1746]? In that patch, {{bigtop_utils}} is a Puppet
module which would house puppet stuff (Ruby parser functions, etc). I don't
think it would be appropriate to put this program there as it is separate from
puppet in the same manner as other tools in the {{bigtop-utils}} rpm package
such as {{init-hcfs.groovy}}. The configure program could be used after puppet
apply to tweak say, yarn settings.
> puppet: Allow merging arbitrary site configuration
> --------------------------------------------------
>
> Key: BIGTOP-1689
> URL: https://issues.apache.org/jira/browse/BIGTOP-1689
> Project: Bigtop
> Issue Type: Improvement
> Components: deployment
> Affects Versions: 0.8.0
> Reporter: Peter Slawski
> Assignee: Peter Slawski
> Fix For: 1.0.0
>
> Attachments: BIGTOP-1689.1.patch
>
>
> Puppet should be flexible in allowing arbitrary configuration name value
> pairs to be merged into a given site.xml file that was generated from a
> template.
> For example, the following could be included in site.yaml which would add a
> configuration entry for hadoop.tmp.dir in core-site.xml:
> {code}
> hadoop::common_hdfs::hadoop_core_site_overrides:
> "hadoop.tmp.dir": "/mnt/var/lib/hadoop/tmp"
> {code}
> This could be implemented as a puppet custom-function taking in the output of
> template:
> {code}
> file {
> "/etc/hadoop/conf/core-site.xml":
> content => merge_site(template('hadoop/core-site.xml'),
> $hadoop_core_site_overrides)
> require => [Package["hadoop"]],
> }
> {code}
> Perhaps another approach would be to have site.xml templates be created from
> a single map of name value pairs. The merge would happen before the file
> content is generated from the template.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
