Github user mxm commented on the pull request:

    https://github.com/apache/bigtop/pull/101#issuecomment-214375936
  
    Tested the RPM package on Fedora 23. First, a bit of a disappointment: 
    
    ```bash
    ● jobmanager.service - LSB: Flink jobmanager
       Loaded: loaded (/etc/rc.d/init.d/jobmanager)
       Active: failed (Result: exit-code) since Mon 2016-04-25 16:40:45 CEST; 
16s ago
         Docs: man:systemd-sysv-generator(8)
      Process: 13344 ExecStart=/etc/rc.d/init.d/jobmanager start (code=exited, 
status=127)
    
    Apr 25 16:40:41 localhost.localdomain jobmanager[13344]: 
/etc/rc.d/init.d/jobmanager: line 34: /lib/lsb/init-functions: No such file or 
directory
    Apr 25 16:40:41 localhost.localdomain jobmanager[13344]: 
/etc/rc.d/init.d/jobmanager: line 74: log_success_msg: command not found
    Apr 25 16:40:41 localhost.localdomain jobmanager[13344]: 
/etc/rc.d/init.d/jobmanager: line 120: pidofproc: command not found
    Apr 25 16:40:41 localhost.localdomain su[13386]: (to flink) root on none
    Apr 25 16:40:45 localhost.localdomain jobmanager[13344]: 
/etc/rc.d/init.d/jobmanager: line 120: pidofproc: command not found
    Apr 25 16:40:45 localhost.localdomain jobmanager[13344]: 
/etc/rc.d/init.d/jobmanager: line 102: log_failure_msg: command not found
    Apr 25 16:40:45 localhost.localdomain systemd[1]: jobmanager.service: 
Control process exited, code=exited status=127
    Apr 25 16:40:45 localhost.localdomain systemd[1]: Failed to start LSB: 
Flink jobmanager.
    Apr 25 16:40:45 localhost.localdomain systemd[1]: jobmanager.service: Unit 
entered failed state.
    Apr 25 16:40:45 localhost.localdomain systemd[1]: jobmanager.service: 
Failed with result 'exit-code'.
    ```
    
    Turns out, it works when you install `lsb` or more specifically 
`redhat-lsb-core`:
    
    ```bash
    ● jobmanager.service - LSB: Flink jobmanager
       Loaded: loaded (/etc/rc.d/init.d/jobmanager)
       Active: active (exited) since Mon 2016-04-25 16:42:56 CEST; 2s ago
         Docs: man:systemd-sysv-generator(8)
      Process: 14071 ExecStart=/etc/rc.d/init.d/jobmanager start (code=exited, 
status=0/SUCCESS)
    
    Apr 25 16:42:56 localhost.localdomain systemd[1]: Starting LSB: Flink 
jobmanager...
    Apr 25 16:42:56 localhost.localdomain jobmanager[14071]: Starting Flink 
jobmanager (flink-jobmanager):[  OK  ]
    Apr 25 16:42:56 localhost.localdomain jobmanager[14071]: Flink jobmanager 
is running[  OK  ]
    Apr 25 16:42:56 localhost.localdomain systemd[1]: Started LSB: Flink 
jobmanager.
    
    ● taskmanager.service - LSB: Flink taskmanager
       Loaded: loaded (/etc/rc.d/init.d/taskmanager)
       Active: active (exited) since Mon 2016-04-25 16:44:28 CEST; 22s ago
         Docs: man:systemd-sysv-generator(8)
      Process: 15428 ExecStart=/etc/rc.d/init.d/taskmanager start (code=exited, 
status=0/SUCCESS)
    
    Apr 25 16:44:25 localhost.localdomain systemd[1]: Starting LSB: Flink 
taskmanager...
    Apr 25 16:44:25 localhost.localdomain taskmanager[15428]: Starting Flink 
taskmanager (flink-taskmanager):[  OK  ]
    Apr 25 16:44:25 localhost.localdomain su[15483]: (to flink) root on none
    Apr 25 16:44:28 localhost.localdomain taskmanager[15428]: Started Flink 
taskmanager (flink-taskmanager):[  OK  ]
    Apr 25 16:44:28 localhost.localdomain systemd[1]: Started LSB: Flink 
taskmanager.
    ```
    
    So we need to add `lsb` as a dependency for Flink. Or do we assume people 
have it installed?
    
    The jobmanager/taskmanager came up fine. I wonder, should we rename the 
service to `flink-master` and `flink-worker`? Or `flink-jobmanager` and 
`flink-taskmanager`? Simply TaskManager and JobManager could confuse people.
    
    Another thing, the logs are named 
"flink-flink-jobmanager-0-localhost.localdomain.log". Probably could remove the 
`flink-flink` prefix.
    
    Other than that, great work :+1: 
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to