Github user oflebbe commented on the pull request:
https://github.com/apache/bigtop/pull/101#issuecomment-214508154
Hi. My Nitty picky comment:
Please see
https://cwiki.apache.org/confluence/display/BIGTOP/Bigtop+Packaging on how to
patch sources. (you may have a look at the hive or zookeeper packages for
examples)
Short : rename 1837.patch to patch1-1837.patch . Insert the magic patterns
into the spec file. remove the patch command from the do-component-build.
In order to get committed the patch on the branch has to be collapsed to
only one patch with the exact message as the JIRA.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
