Github user rmetzger commented on the pull request:
https://github.com/apache/bigtop/pull/101#issuecomment-214785025
Thank you for the review @mxm!
Regarding the lsb dependency: I saw that the Hadoop spec for example has
the following entry:
```
Requires: sh-utils, /lib/lsb/init-functions
```
I guess we can add that as well.
> I wonder, should we rename the service to flink-master and flink-worker?
Or flink-jobmanager and flink-taskmanager? Simply TaskManager and JobManager
could confuse people.
I'm definitively against `flink-master`, `flink-worker`, because that's not
an "official" terminology (at least in the Flink code we call them job- and
taskmanager).
I also thought about `flink-jobmanager` and `flink-taskmanager`. Any other
thoughts on this?
> Another thing, the logs are named
"flink-flink-jobmanager-0-localhost.localdomain.log". Probably could remove the
flink-flink prefix.
The naming schema for logs is
`flink-<username>-<component>-<instance>-<host>.<log|out>`. By starting the
flink services with the `flink` user, we end up with that ugliness.
I'll look into it and try to see if I can change the behavior easily (the
problem is that I need to create patches if I want to change anything on the
flink source, and I want to avoid patching too much for bigtop).
@oflebbe: I'll check the guide again and adopt the patch integration
accordingly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
