Also, we realized that while we did internal review among the four of us of the PRs we created, we didn't document those reviews on the Jira tickets. I'd like to have us go back and re-review those to have it documented on the Jira tickets exactly what we did to test those charms and what the results were, which I think would be very helpful for your review.
On Tue, Jul 19, 2016 at 2:11 PM, Cory Johns <[email protected]> wrote: > Roman, > > Can you explain a bit more about the Bigtop branch workflow? We certainly > want to make sure we follow the best practices to make reviewing our > proposals as easy as possible, and we realize that introducing a new tool > (Juju) adds a barrier as it is. > > On Mon, Jul 18, 2016 at 8:38 PM, Roman Shaposhnik <[email protected]> wrote: > >> Hi! >> >> going over amazing work that Canonical folks are >> pushing our way: >> https://github.com/apache/bigtop/pulls >> made me realize that a piecemeal approach to >> reviewing and committing those patches probably >> is not going to work for. At least not for me. >> >> The challenge is that there's a certain degree of >> interdependency that makes it difficult to review >> standalone patches. >> >> This is the kind of work that is meant to be done >> on a branch. Canonical folks, however, are >> not Bigtop committers which makes a self-managed >> branch not an option for them. >> >> What would be the best way to facilitate their work? >> Anybody has any thoughts on that? >> >> Thanks, >> Roman. >> > >
