Hi All, > I don't think a mega PR will help with the issue much, as the review of > mega-anything is a mega-PITA.
A mega PR sounds like a hassle to me, too. :-) Maybe we're misunderstanding what you're asking us to do. > Sometimes these fixes are intertwined with the charms and that's where the snug is: most of us don't have enough hands-on experience with Juju at this point to make an informed review and/or test the changes (as has been discussed earlier). Would it help to put a charm and the puppet changes in the same PR? I know that I generally try to separate them, partially to encourage myself to only make puppet changes that make sense alone, outside of the context of a charm. I do tend to validate and test inside a charm, though. Is testing the main blocker? I typically test by building a charm and then using bundletester to deploy the charm to AWS and run tests, including the Bigtop smoke tests. If anybody needs an AWS account for charm testing purposes, they can go to https://developer.juju.solutions/ and set one up. I made some improvements to the juju documentation on running tests ( https://jujucharms.com/docs/stable/developer-testing#executing-tests-via-bundletester), but I'm happy to help people out on IRC if anything is unclear (more feedback means that I can write better documentation). Regards, ~ PeteVG
