The individual Jiras that we proposed should be self-contained if we don't mark them as dependent on another Jira ticket and ready for review if they have a patch attached.
The issue with the bigtop-base layer having to live outside the Bigtop repo is a limitation of the charm-build tooling ( https://github.com/juju/charm-tools/issues/212) and I don't think it will be resolved soon. However, the build process is always going to depend on some external layers, such as the reactive base layer, and some interface layers. This is just an aspect of how building charms from layers works. Do you consider this an issue for the charms in Bigtop? We tend to think of it like a "compile" step for the charms and the layers pulled from http://interfaces.juju.solutions/ to be analogous to using libraries from PyPI. On Tue, Jul 19, 2016 at 6:13 PM, Roman Shaposhnik <[email protected]> wrote: > On Tue, Jul 19, 2016 at 3:06 PM, Cory Johns <[email protected]> > wrote: > > Also, we realized that while we did internal review among the four of us > of > > the PRs we created, we didn't document those reviews on the Jira tickets. > > I'd like to have us go back and re-review those to have it documented on > > the Jira tickets exactly what we did to test those charms and what the > > results were, which I think would be very helpful for your review. > > Sure that would be helpful, but like I said -- my biggest hurdle is not > being > able to see forest for the trees. That's why I can't really review > much as it stands. > > Well, I suppose I can recreate that branch I'm talking about myself, > but I'd rather > you guys maintained it ;-) > > Thanks, > Roman. >
