Github user kwmonroe commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/344#discussion_r171912318
--- Diff: bigtop-packages/src/charm/hive/layer-hive/reactive/hive.py ---
@@ -78,9 +87,13 @@ def install_hive(hadoop):
else:
hbserver = None
+ # Get zookeepers or None
+ zks = KV.get('zookeepers', None)
--- End diff --
I'm curious why we're using `unitdata.kv` here. If you look a few lines
higher at the hbase block, we could use the same logic to get zks when
`is_state(zookeeper.ready)` is available.
---