Github user jamesbeedy commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/344#discussion_r172086152
--- Diff:
bigtop-packages/src/charm/hive/layer-hive/lib/charms/layer/bigtop_hive.py ---
@@ -36,31 +36,45 @@ def install(self, hbase=None):
# Prep config
roles = ['hive-client', 'hive-metastore', 'hive-server2']
metastore = "thrift://{}:9083".format(hookenv.unit_private_ip())
- if hbase:
- roles.append('hive-hbase')
- hb_connect = "{}:{}".format(hbase['host'],
hbase['master_port'])
- zk_connect = hbase['zk_connect']
- else:
- hb_connect = ""
- zk_connect = ""
--- End diff --
@kwmonroe totally, nice catch. I'll set those bits appropriately.
---
