+1, lgtm! -Flavio
> On 23 May 2015, at 03:13, Rakesh Radhakrishnan <[email protected]> > wrote: > > Great work Sijie! > > +1 looks fine for me. > > -Rakesh > > On Thu, May 21, 2015 at 2:17 AM, Ivan Kelly <[email protected]> wrote: > >> lgtm +1 >> >> Good work Sijie! >> >> -Ivan >> >> On Wed, May 20, 2015 at 7:46 AM, Sijie Guo <[email protected]> wrote: >>> This is the second release candidate for Apache BookKeeper, version >> 4.3.1. >>> It fixes the following issues: >>> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12328755&styleName=Html&projectId=12311293 >>> >>> *** Please download, test and vote by May 23rd 2015, 10:00 GMT. >>> >>> Note that we are voting upon the source (tag), binaries are provided for >>> convenience. >>> >>> Source and binary files: >>> >> https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.3.1-candidate-1/ >>> >>> Maven staging repo: >>> >> https://repository.apache.org/content/repositories/orgapachebookkeeper-1006/ >>> >>> The tag to be voted upon: >>> release-4.3.1 (de41dbb2332b7345f8362247d5b8389ec81399fa) >>> >>> BookKeeper's KEYS file containing PGP keys we use to sign the release: >>> https://dist.apache.org/repos/dist/release/bookkeeper/KEYS >>> >>> Please download the the source package, and follow the README to build >>> and run a bookkeeper and hedwig service. >>
