> Perhaps we should consider moving hedwig to a contrib folder for future 
> releases then...

I'd just straight remove it. Noone is using it afaik, and contrib
module tend to rot. It'll still be in the git history.

-Ivan

On Sun, May 24, 2015 at 10:11 AM, Flavio Junqueira
<[email protected]> wrote:
>
>> On 24 May 2015, at 05:45, Sijie Guo <[email protected]> wrote:
>>
>> On Sat, May 23, 2015 at 1:36 PM, Flavio Junqueira <
>> [email protected]> wrote:
>>
>>> A couple more questions:
>>>
>>> - Are we enforcing that hedwig tests pass? The bookkeeper tests pass fine
>>> for me, but not the hedwig ones, they are a bit flaky.
>>>
>>
>> I think we should just ignore hedwig ones, since they are inactive for a
>> long time.
>
> Perhaps we should consider moving hedwig to a contrib folder for future 
> releases then...
>
>>
>>
>>> - The rat check complains about jms:
>>>
>>>        [ERROR] Failed to execute goal
>>> org.apache.rat:apache-rat-plugin:0.7:check
>>>        (default-cli) on project hedwig-client-jms: Too many unapproved
>>> licenses: 1 -> [Help 1]
>>>
>>>  I think this is a problem, no?
>>>
>>
>> I ran mvn apache-rat:check. It is good. Did you run 'mvn clean' before
>> 'apache-rat:check'?
>>
>
> I did and I still get the same error, I'll need to check why I'm getting this.
>
> -Flavio
>
>>>
>>>> On 23 May 2015, at 11:51, Flavio Junqueira <[email protected]>
>>> wrote:
>>>>
>>>> Yep, I forgot about that, thanks for the reminder. I'm re-running tests
>>> and it is going fine so far.
>>>>
>>>> -Flavio
>>>>
>>>>> On 23 May 2015, at 01:03, Sijie Guo <[email protected]> wrote:
>>>>>
>>>>> Hi Flavio:
>>>>>
>>>>> I think the problem is still the hostname of your azure vm as last time.
>>>>> You fixed it by adding entry to /etc/hosts file last time. Could you do
>>>>> similar this time?
>>>>>
>>>>> - Sijie
>>>>>
>>>>>
>>>>>
>>>>> On Fri, May 22, 2015 at 4:11 PM, Flavio Junqueira <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> I'm still getting some failures on an azure vm with ubuntu and jdk 8:
>>>>>>
>>>>>>      Results :
>>>>>>
>>>>>>      Failed tests:
>>>>>> testManyLedgers(org.apache.bookkeeper.client.UpdateLedgerOpTest):
>>> Failed
>>>>>> to update the ledger metadata to use bookie host name
>>>>>>
>>>>>>
>>> testLimitLessThanTotalLedgers(org.apache.bookkeeper.client.UpdateLedgerOpTest):
>>>>>> Failed to update the ledger metadata to use bookie host name
>>> expected:<4>
>>>>>> but was:<10>
>>>>>>
>>>>>>
>>> testRestartWithIpAddressAsBookieID(org.apache.bookkeeper.bookie.CookieTest):
>>>>>> Fails to recognize bookie which was started with HostName as ID
>>>>>>
>>>>>>      Tests in error:
>>>>>>
>>>>>>
>>> testUpdateCookieHostnameToIpAddress(org.apache.bookkeeper.bookie.UpdateCookieCmdTest):
>>>>>> KeeperErrorCode = NoNode for /ledgers/cookies/10.0.0.4:15003
>>>>>>
>>>>>>
>>> testWhenBothIPaddressAndHostNameCookiesExists(org.apache.bookkeeper.bookie.UpdateCookieCmdTest):
>>>>>> KeeperErrorCode = NoNode for /ledgers/cookies/10.0.0.4:15005
>>>>>>
>>>>>>
>>> testUpdateCookieIpAddressToHostname(org.apache.bookkeeper.bookie.UpdateCookieCmdTest):
>>>>>> KeeperErrorCode = NoNode for /ledgers/cookies/10.0.0.4:15006
>>>>>>      testWriteGaps(org.apache.bookkeeper.test.BookieClientTest)
>>>>>>
>>>>>>      Tests run: 582, Failures: 3, Errors: 4, Skipped: 0
>>>>>>
>>>>>> and the logs are here:
>>>>>>
>>>>>>      http://people.apache.org/~fpj/bk-4.3.1-rc1/
>>>>>>
>>>>>> in the case anyone is interested in having a look.
>>>>>>
>>>>>> -Flavio
>>>>>>
>>>>>>
>>>>>>> On 20 May 2015, at 06:46, Sijie Guo <[email protected]> wrote:
>>>>>>>
>>>>>>> This is the second release candidate for Apache BookKeeper, version
>>>>>> 4.3.1.
>>>>>>> It fixes the following issues:
>>>>>>>
>>>>>>
>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12328755&styleName=Html&projectId=12311293
>>>>>>>
>>>>>>> *** Please download, test and vote by May 23rd 2015, 10:00 GMT.
>>>>>>>
>>>>>>> Note that we are voting upon the source (tag), binaries are provided
>>> for
>>>>>>> convenience.
>>>>>>>
>>>>>>> Source and binary files:
>>>>>>>
>>>>>>
>>> https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.3.1-candidate-1/
>>>>>>>
>>>>>>> Maven staging repo:
>>>>>>>
>>>>>>
>>> https://repository.apache.org/content/repositories/orgapachebookkeeper-1006/
>>>>>>>
>>>>>>> The tag to be voted upon:
>>>>>>> release-4.3.1 (de41dbb2332b7345f8362247d5b8389ec81399fa)
>>>>>>>
>>>>>>> BookKeeper's KEYS file containing PGP keys we use to sign the release:
>>>>>>> https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
>>>>>>>
>>>>>>> Please download the the source package, and follow the README to build
>>>>>>> and run a bookkeeper and hedwig service.
>>>>>>
>>>>>>
>>>>
>>>
>>>
>

Reply via email to