[
https://issues.apache.org/jira/browse/BOOKKEEPER-933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15339632#comment-15339632
]
Enrico Olivelli commented on BOOKKEEPER-933:
--------------------------------------------
IMHO It would be usefull to add a system property to enable the previous
behaviour.
For instance in some production system we (Diennea) used this trick to hack
client configuration to disable client side throttling without changing the
code.
something like:
{code}
private static final boolean APPLY_SYSTEM_PROPERTIES
=
Boolean.getBoolean("org.apache.bookkeeper.readsystemproperties");
protected AbstractConfiguration() {
super();
if (APPLY_SYSTEM_PROPERTIES) {
// add configuration for system properties
addConfiguration(new SystemConfiguration());
}
}
{code}
> ClientConfiguration always inherits System properties
> -----------------------------------------------------
>
> Key: BOOKKEEPER-933
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-933
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-client
> Reporter: Enrico Olivelli
> Assignee: Enrico Olivelli
> Fix For: 4.5.0
>
>
> ClientConfiguration is always adding System.getProperties()
> {code}
> protected AbstractConfiguration() {
> super();
> // add configuration for system properties
> addConfiguration(new SystemConfiguration());
> }
> {code}
> This is useful is some cases but sometimes it is very harmful because the
> user could modify the client behaviour inadvertently, for instance::
> throttle, readTimeout....
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
