[
https://issues.apache.org/jira/browse/BOOKKEEPER-933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15400971#comment-15400971
]
ASF GitHub Bot commented on BOOKKEEPER-933:
-------------------------------------------
Github user sijie commented on the issue:
https://github.com/apache/bookkeeper/pull/50
The change looks good to me +1. Thanks @eolivelli
> ClientConfiguration always inherits System properties
> -----------------------------------------------------
>
> Key: BOOKKEEPER-933
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-933
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-client
> Reporter: Enrico Olivelli
> Assignee: Enrico Olivelli
> Fix For: 4.5.0
>
>
> ClientConfiguration is always adding System.getProperties()
> {code}
> protected AbstractConfiguration() {
> super();
> // add configuration for system properties
> addConfiguration(new SystemConfiguration());
> }
> {code}
> This is useful is some cases but sometimes it is very harmful because the
> user could modify the client behaviour inadvertently, for instance::
> throttle, readTimeout....
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
