[
https://issues.apache.org/jira/browse/BOOKKEEPER-933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15343852#comment-15343852
]
ASF GitHub Bot commented on BOOKKEEPER-933:
-------------------------------------------
GitHub user eolivelli opened a pull request:
https://github.com/apache/bookkeeper/pull/50
BOOKKEEPER-933 ClientConfiguration always inherits System properties
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/eolivelli/bookkeeper BOOKKEEPER-933
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bookkeeper/pull/50.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #50
----
commit beb68fb6a9f6fb0d730f149e1eddd995289d86cd
Author: eolivelli <[email protected]>
Date: 2016-06-22T07:37:44Z
BOOKKEEPER-933 ClientConfiguration always inherits System properties
commit 0bcae1e6b783522ee3072166dc9ca7e2f0351f28
Author: eolivelli <[email protected]>
Date: 2016-06-22T07:38:11Z
BOOKKEEPER-933 ClientConfiguration always inherits System properties
----
> ClientConfiguration always inherits System properties
> -----------------------------------------------------
>
> Key: BOOKKEEPER-933
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-933
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-client
> Reporter: Enrico Olivelli
> Assignee: Enrico Olivelli
> Fix For: 4.5.0
>
>
> ClientConfiguration is always adding System.getProperties()
> {code}
> protected AbstractConfiguration() {
> super();
> // add configuration for system properties
> addConfiguration(new SystemConfiguration());
> }
> {code}
> This is useful is some cases but sometimes it is very harmful because the
> user could modify the client behaviour inadvertently, for instance::
> throttle, readTimeout....
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
