I filed an issue for the problem discussed here: https://github.com/apache/bookkeeper/issues/659
- Sijie On Tue, Oct 24, 2017 at 2:06 PM, Charan Reddy G <reddychara...@gmail.com> wrote: > Sure Sijie and Ivan. It sounds appropriate. > > Thanks, > Charan > > On Tue, Oct 24, 2017 at 1:00 AM, Sijie Guo <guosi...@gmail.com> wrote: > >> Yes, we should fix this ASAP. >> >> Charan, what is your opinion on the fix? >> >> - Sijie >> >> On Tue, Oct 24, 2017 at 12:12 AM, Ivan Kelly <iv...@apache.org> wrote: >> >>> > Use the approach that I used before (as in the old commits at twitter’s >>> > branch). Ledger storage is responsible for instantiating the >>> checkpoints. >>> I would go with this approach. It was probably me that asked for the >>> changes in the other direction before, but I can't remember why I >>> asked for them, so the view held strongly then isn't held strongly >>> now. >>> >>> It would be good to get this change in soon, so that when the yahoo >>> DbLedgerStorage goes in, we can verify that checkpointing works as >>> expected. >>> >>> -Ivan >>> >> >> >
