On Oct 25, 2017 12:53 AM, "Enrico Olivelli - Diennea" < enrico.olive...@diennea.com> wrote:
Il giorno mar, 24/10/2017 alle 15.41 -0700, Sijie Guo ha scritto: I filed an issue for the problem discussed here: https://github.com/apache/bookkeeper/issues/659 Sijie, Charan, thank you for catching this IMHO we should take options 1 o 2 as Sijie proposed I think we agreed on option 1. Sijie, Do you have an approximate idea about affected versions 4.3, 4.4, 4.5 ? I think it impacts all those versions at sorted ledger storage, when compaction happens to advance the checkpoint holder. Sijie Enrico - Sijie On Tue, Oct 24, 2017 at 2:06 PM, Charan Reddy G <reddychara...@gmail.com< mailto:reddychara...@gmail.com>> wrote: Sure Sijie and Ivan. It sounds appropriate. Thanks, Charan On Tue, Oct 24, 2017 at 1:00 AM, Sijie Guo <guosi...@gmail.com<mailto:guo si...@gmail.com>> wrote: Yes, we should fix this ASAP. Charan, what is your opinion on the fix? - Sijie On Tue, Oct 24, 2017 at 12:12 AM, Ivan Kelly <iv...@apache.org<mailto:ivank @apache.org>> wrote: Use the approach that I used before (as in the old commits at twitter’s branch). Ledger storage is responsible for instantiating the checkpoints. I would go with this approach. It was probably me that asked for the changes in the other direction before, but I can't remember why I asked for them, so the view held strongly then isn't held strongly now. It would be good to get this change in soon, so that when the yahoo DbLedgerStorage goes in, we can verify that checkpointing works as expected. -Ivan -- Enrico Olivelli Software Development Manager @Diennea Tel.: (+39) 0546 066100 - Int. 925 Viale G.Marconi 30/14 - 48018 Faenza (RA) MagNews - E-mail Marketing Solutions http://www.magnews.it Diennea - Digital Marketing Solutions http://www.diennea.com ________________________________ Iscriviti alla nostra newsletter per rimanere aggiornato su digital ed email marketing! http://www.magnews.it/newsletter/ The information in this email is confidential and may be legally privileged. If you are not the intended recipient please notify the sender immediately and destroy this email. Any unauthorized, direct or indirect, disclosure, copying, storage, distribution or other use is strictly forbidden.
