GitHub user geomacy opened a pull request:

    https://github.com/apache/brooklyn-server/pull/338

    Not for merge, work in progress - testCatalogItemIdInReferencedItems

    For 
[testCatalogItemIdInReferencedItems](https://github.com/apache/brooklyn-server/blob/master/camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/catalog/CatalogYamlEntityTest.java#L955),
 work in progress.  
    
    Current status, updates BrooklynObject and BrooklynObjectSpec to support 
nested catalogItemIds. This lets testCatalogItemIdInReferencedItems work in its 
modified form, i.e. it correctly identifies the nested items structure of 
outer/inner, but there is still plenty to do as noted below. The unit tests of 
brooklyn-server all work with this change in place, but will have to think 
about how to get good enough test coverage in place for this when remaining 
changes are done.
    
    ### TODO:
    * doesn't include changes to persistence to allow the nested item ids to be 
persisted and retrieved during rebind
    * Need to review what changes may be needed to EntityTransientCopyInternal.
    * Looks like catalogItemIdIfNotNull can be removed.
    
    ### Things to review
    Everything, really; but some things I made a note of particularly
    * review places where setCatalogItemIdIfNotNull has been replaced with 
nestCatalogItemIds and see if they make sense from a sanity viewpoint
    * review use of setCatalogItemIds()
    
    
    
     

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/geomacy/brooklyn-server catalog-update

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/338.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #338
    
----
commit 0b4fc215d32a274f5839cbe18d54f1c0d6959074
Author: Geoff Macartney <geoff.macart...@cloudsoftcorp.com>
Date:   2016-09-14T13:44:14Z

    Osgi loader change

commit 3f97a65c7222fd30ebbf3137b02e2db9e51214d0
Author: Geoff Macartney <geoff.macart...@cloudsoftcorp.com>
Date:   2016-09-19T13:22:43Z

    Add nested catalog item ids to AbstractBrooklynObjectSpec.

commit 6f73177888fd332e56be4ed61a371617095950b8
Author: Geoff Macartney <geoff.macart...@cloudsoftcorp.com>
Date:   2016-09-20T10:16:36Z

    Add catalog item super id support.

commit b945ec1865b11ef0477fb77a54d7863bc4409108
Author: Geoff Macartney <geoff.macart...@cloudsoftcorp.com>
Date:   2016-09-20T14:51:47Z

    Fixes to get CatalogYamlEntityTest.testCatalogItemIdInReferencedItems 
working.
    
    Haven't re-run all unit tests yet.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to