Github user geomacy commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/338#discussion_r79871837
  
    --- Diff: 
core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogItemDtoAbstract.java
 ---
    @@ -45,6 +45,8 @@
     import com.google.common.collect.Iterables;
     import com.google.common.collect.Sets;
     
    +// TODO add support for nested catalog items, implement nestCatalogItemId 
in terms of symbolicName/Version
    +// TODO also getCatalogItemSuperIds.
    --- End diff --
    
    Comment from @neykov 
([here](https://github.com/neykov/brooklyn-server/pull/3#discussion_r79803420)):
    
    I think we should either override with NOPs, or just keep the default 
behaviour from AbstractBrooklynObject. The catalog items don't know what's the 
meaning of the plan in them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to