Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/338#discussion_r94618204
  
    --- Diff: 
api/src/main/java/org/apache/brooklyn/api/internal/AbstractBrooklynObjectSpec.java
 ---
    @@ -187,7 +202,24 @@ public final String getDisplayName() {
         }
         
         public final String getCatalogItemId() {
    -        return catalogItemId;
    +        if (catalogItemIdStack.size() != 0) {
    +            return catalogItemIdStack.getFirst();
    +        }
    +        return null;
    +    }
    +
    +    /**
    +     * An immutable list of ids of this object's catalog item and its 
defining catalog items.
    +     * e.g. if the catalog item is defined as
    +     * <pre>
    +     *     items:
    +     *     - id: X
    +     *       item: Y
    +     * </pre>
    +     * then the list will contain X, Y.
    +     */
    +    public final List<String> getCatalogItemSuperIds() {
    --- End diff --
    
    `Super` (here and same name in other classes) could be misinterpreted as in 
"don't include the outer-most item" - just leave it out? Alternatives: 
`getCatalogItemHierarchy`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to