Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/414#discussion_r87088045
--- Diff:
test-framework/src/main/java/org/apache/brooklyn/test/framework/TestHttpCall.java
---
@@ -32,9 +36,34 @@
@SetFromFlag(nullable = false)
ConfigKey<String> TARGET_URL = ConfigKeys.newStringConfigKey("url",
"URL to test");
+ @SetFromFlag(nullable = false)
+ ConfigKey<HttpMethod> TARGET_METHOD =
ConfigKeys.builder(HttpMethod.class)
+ .name("method")
+ .description("Method to request the URL: GET, POST, PUT,
DELETE, etc")
+ .defaultValue(HttpMethod.GET)
+ .build();
+
+ @SetFromFlag
--- End diff --
I believe you would still be able to set it outside of the
`brooklyn.config:` block in yaml. See
https://github.com/apache/brooklyn-server/pull/418 for a new test that
demonstrates this.
We should get rid of all the `@SetFromFlag`s, where it's not adding
additional info (e.g. to say non-null or such like).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
