Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/414#discussion_r87090913
--- Diff:
test-framework/src/test/java/org/apache/brooklyn/test/framework/TestHttpCallTest.java
---
@@ -87,6 +96,11 @@ public void testHttpBodyAssertions() {
.configure(TestHttpCall.TARGET_URL, server.getUrl() +
"/body.json")
.configure(TestHttpCall.TIMEOUT, new Duration(10L,
TimeUnit.SECONDS))
.configure(TestSensor.ASSERTIONS, newAssertion("matches",
".*123.*")));
+ app.createAndManageChild(EntitySpec.create(TestHttpCall.class)
+ .configure(TestHttpCall.TARGET_URL, server.getUrl() +
"/foo/bar")
+ .configure(TestHttpCall.TARGET_METHOD,
TestHttpCall.HttpMethod.POST)
+ .configure(TestHttpCall.TIMEOUT, new Duration(10L,
TimeUnit.SECONDS))
--- End diff --
Personal preference: we should use `Asserts.DEFAULT_LONG_TIMEOUT` rather
than our code being littered with arbitrary timeouts. In my opinion, the only
time one should set different timeouts for something we expect to not timeout
is if it's a performance test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
