Github user neykov commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/338#discussion_r94621436
  
    --- Diff: 
core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogUtils.java 
---
    @@ -170,6 +173,13 @@ public static void installLibraries(ManagementContext 
managementContext, @Nullab
         public static String 
getCatalogItemIdFromLoader(BrooklynClassLoadingContext loader) {
             if (loader instanceof OsgiBrooklynClassLoadingContext) {
                 return 
((OsgiBrooklynClassLoadingContext)loader).getCatalogItemId();
    +        } else if (loader instanceof 
BrooklynClassLoadingContextSequential) {
    +            final Iterator<BrooklynClassLoadingContext> iterator = 
((BrooklynClassLoadingContextSequential) loader).getPrimaries().iterator();
    +            if (iterator.hasNext()) {
    +                BrooklynClassLoadingContext osgiLoader = iterator.next();
    +                return getCatalogItemIdFromLoader(osgiLoader);
    +            }
    +            else return null;
    --- End diff --
    
    Can you remind me, is this still needed? What was the use case.
    Should it return a list of catalog ids now?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to