Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/520#discussion_r96848337
--- Diff:
software/base/src/main/java/org/apache/brooklyn/entity/software/base/SoftwareProcessDriverLifecycleEffectorTasks.java
---
@@ -169,7 +173,7 @@ protected String startProcessesAtMachine(final
Supplier<MachineLocation> machine
}
@Override
- protected void postStartCustom() {
+ protected void postStartCustom(AtomicReference<ReleaseableLatch>
startLatchRef) {
--- End diff --
There are subclasses of `SoftwareProcessDriverLifecycleEffectorTasks` and
`MachineLifecycleEffectorTasks` in brooklyn-library (e.g.
https://github.com/apache/brooklyn-library/blob/master/software/cm/ansible/src/main/java/org/apache/brooklyn/entity/cm/ansible/AnsibleLifecycleEffectorTasks.java#L138,
which should really have an `@Override` annotation) and elsewhere in the wild
so we should at least deprecate the no-arg methods.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
