Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/520#discussion_r96905127
--- Diff:
software/base/src/main/java/org/apache/brooklyn/entity/software/base/SoftwareProcessDriverLifecycleEffectorTasks.java
---
@@ -169,7 +173,7 @@ protected String startProcessesAtMachine(final
Supplier<MachineLocation> machine
}
@Override
- protected void postStartCustom() {
+ protected void postStartCustom(AtomicReference<ReleaseableLatch>
startLatchRef) {
--- End diff --
I was wondering how to do that in a backwards way. Couldn't think of a good
solution.
If we keep the old signature it won't get called so it's actually worse
than getting a compile error.
Could do something with thread locals, calling the deprecated method and
passing the argument. Do you think that's something worth doing?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
