Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/480#discussion_r101789828
  
    --- Diff: 
camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/methods/DslComponent.java
 ---
    @@ -539,8 +550,9 @@ protected String resolveKeyName(boolean immediately) {
             @Override
             public final Maybe<Object> getImmediately() {
                 Maybe<Entity> targetEntityMaybe = component.getImmediately();
    -            if (targetEntityMaybe.isAbsent()) return Maybe.absent("Target 
entity not available");
    +            if (targetEntityMaybe.isAbsent()) return 
Maybe.<Object>cast(targetEntityMaybe);
                 EntityInternal targetEntity = (EntityInternal) 
targetEntityMaybe.get();
    +            checkAndTagForRecursiveReference(targetEntity);
    --- End diff --
    
    If I'm reading this right... it adds the tag to the current task, but then 
the tag is not removed at the end of this method - should it be?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to