Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/480#discussion_r101782727
  
    --- Diff: 
api/src/main/java/org/apache/brooklyn/api/mgmt/ExecutionContext.java ---
    @@ -64,4 +65,6 @@
     
         boolean isShutdown();
     
    +    <T> Maybe<T> getImmediately(Object callableOrSupplier);
    --- End diff --
    
    Worth adding javadoc here - e.g. similar to what you've added in the impl 
`BasicExecutionContext`. Worth saying when it will return Maybe.absent (e.g. if 
the task execution requires blocking for other work, and can't complete in a 
timely fashion).



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to