Github user andreaturli commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/849#discussion_r142133279
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
---
@@ -2957,7 +2957,7 @@ String getHostnameAws(HostAndPort hostAndPort,
LoginCredentials userCredentials,
"get public AWS hostname",
ImmutableList.of(
BashCommands.INSTALL_CURL,
- "echo `curl --silent --retry 20
http://169.254.169.254/latest/meta-data/public-hostname`; exit"));
+ "echo `curl --silent --retry 20
http://169.254.169.254/latest/meta-data/"+(privateHost ? "local-hostname" :
"public-hostname")+"`; exit"));
--- End diff --
thanks @tbouron, could we avoid the extra boolean parameter if we use
something like
```
response=$(curl --write-out %{http_code} --silent --output /dev/null
http://169.254.169.254/latest/meta-data/local-hostname)
if [ $(response) == "200" ] ;
then
echo `curl --silent --retry 20
http://169.254.169.254/latest/meta-data/privateHost"`; exit"));
else
echo `curl --silent --retry 20
http://169.254.169.254/latest/meta-data/public-hostname"`; exit"));
```
or something similar?
---
