[GitHub] brooklyn-server pull request #849: Retrieve the right AWS metadata for priva...

[andreaturli]

Github user andreaturli commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/849#discussion_r142167369
  
    --- Diff: 
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
 ---
    @@ -2957,7 +2957,7 @@ String getHostnameAws(HostAndPort hostAndPort, 
LoginCredentials userCredentials,
                         "get public AWS hostname",
                         ImmutableList.of(
                                 BashCommands.INSTALL_CURL,
    -                            "echo `curl --silent --retry 20 
http://169.254.169.254/latest/meta-data/public-hostname`; exit"));
    +                            "echo `curl --silent --retry 20 
http://169.254.169.254/latest/meta-data/"+(privateHost ? "local-hostname" : 
"public-hostname")+"`; exit"));
    --- End diff --
    
    @tbouron if we can rely on jclouds for getting the private hostname 
`NodeMetadata.getHostname`, Brooklyn doesn’t need to calculate a new one 
especially for nodes created using JcloudsLocation. Notice 
`NodeMetadata.getHostname` is nullable so I think JcloudsLocation should manage 
that or assign the value to `host.addresses.private`


---