Github user andreaturli commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/849#discussion_r142146044
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
---
@@ -2957,7 +2957,7 @@ String getHostnameAws(HostAndPort hostAndPort,
LoginCredentials userCredentials,
"get public AWS hostname",
ImmutableList.of(
BashCommands.INSTALL_CURL,
- "echo `curl --silent --retry 20
http://169.254.169.254/latest/meta-data/public-hostname`; exit"));
+ "echo `curl --silent --retry 20
http://169.254.169.254/latest/meta-data/"+(privateHost ? "local-hostname" :
"public-hostname")+"`; exit"));
--- End diff --
not sure I follow, @tbouron -- I think it would be easier to read if we
have 2 methods
`getPrivateAwsHostname` and `getPublicAwsHostname` what do you think?
---
