Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/859#discussion_r145067457
  
    --- Diff: 
core/src/main/java/org/apache/brooklyn/util/core/osgi/BundleMaker.java ---
    @@ -110,8 +110,6 @@ public File createJarFromClasspathDir(String path) {
                     addUrlItemRecursively(zout, path, path, 
Predicates.alwaysTrue());
                 }
                 
    -            Streams.closeQuietly(zout);
    --- End diff --
    
    Yes - it's done in the finally block as well, so this line is redundant 
(admittedly not to do with deprecated code, but is general code cleanup).


---

Reply via email to