Github user tbouron commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/859#discussion_r144589344
  
    --- Diff: 
core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogUtils.java 
---
    @@ -112,8 +112,8 @@ public static BrooklynClassLoadingContext 
newClassLoadingContext(@Nullable Manag
             return newClassLoadingContext(mgmt, catalogItemId, libraries, 
JavaBrooklynClassLoadingContext.create(mgmt));
         }
         
    -    @Deprecated /** @deprecated since 0.9.0; becoming private because we 
should now always have a registered type callers can pass instead of the 
catalog item id */
    -    public static BrooklynClassLoadingContext 
newClassLoadingContext(@Nullable ManagementContext mgmt, String catalogItemId, 
Collection<? extends OsgiBundleWithUrl> libraries, BrooklynClassLoadingContext 
loader) {
    +    @Deprecated /** @deprecated since 0.9.0; we should now always have a 
registered type callers can pass instead of the catalog item id */
    +    private static BrooklynClassLoadingContext 
newClassLoadingContext(@Nullable ManagementContext mgmt, String catalogItemId, 
Collection<? extends OsgiBundleWithUrl> libraries, BrooklynClassLoadingContext 
loader) {
    --- End diff --
    
    Keeping for persistence reason I suppose?


---

Reply via email to