Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/859#discussion_r145063507
--- Diff:
core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogUtils.java
---
@@ -112,8 +112,8 @@ public static BrooklynClassLoadingContext
newClassLoadingContext(@Nullable Manag
return newClassLoadingContext(mgmt, catalogItemId, libraries,
JavaBrooklynClassLoadingContext.create(mgmt));
}
- @Deprecated /** @deprecated since 0.9.0; becoming private because we
should now always have a registered type callers can pass instead of the
catalog item id */
- public static BrooklynClassLoadingContext
newClassLoadingContext(@Nullable ManagementContext mgmt, String catalogItemId,
Collection<? extends OsgiBundleWithUrl> libraries, BrooklynClassLoadingContext
loader) {
+ @Deprecated /** @deprecated since 0.9.0; we should now always have a
registered type callers can pass instead of the catalog item id */
+ private static BrooklynClassLoadingContext
newClassLoadingContext(@Nullable ManagementContext mgmt, String catalogItemId,
Collection<? extends OsgiBundleWithUrl> libraries, BrooklynClassLoadingContext
loader) {
--- End diff --
The other three public methods all delegate to this; we just want this one
to be private.
I expect there's scope to re-write the methods to delete this, but I've not
looked closely (hence leaving it as deprecated).
---
