geomacy commented on a change in pull request #77: Allow sent user defined
headers and omit credentials if not needed
URL: https://github.com/apache/brooklyn-client/pull/77#discussion_r287616429
##########
File path: cli/commands/login.go
##########
@@ -54,7 +54,11 @@ func (cmd *Login) Metadata()
command_metadata.CommandMetadata {
Name: "login",
Description: "Login to brooklyn",
Usage: "BROOKLYN_NAME login URL [USER [PASSWORD]]",
- Flags: []cli.Flag{cli.BoolFlag{Name: "skipSslChecks",
Usage: "Skip SSL Checks"}},
+ Flags: []cli.Flag{
+ cli.BoolFlag{Name: "skipSslChecks", Usage: "Skip SSL
Checks"},
+ cli.BoolFlag{Name: "noCredentials", Usage: "No
user/password needed"},
Review comment:
`noCredentials` is a bad name, you are still supplying credentials, just not
basic auth credentials. See my general remarks for a suggested alternative.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
