geomacy commented on a change in pull request #77: Allow sent user defined
headers and omit credentials if not needed
URL: https://github.com/apache/brooklyn-client/pull/77#discussion_r289196323
##########
File path: cli/commands/login.go
##########
@@ -55,9 +64,9 @@ func (cmd *Login) Metadata()
command_metadata.CommandMetadata {
Description: "Login to brooklyn",
Usage: "BROOKLYN_NAME login URL [USER [PASSWORD]]",
Flags: []cli.Flag{
- cli.BoolFlag{Name: "skipSslChecks", Usage: "Skip SSL
Checks"},
- cli.BoolFlag{Name: "noCredentials", Usage: "No
user/password needed"},
- cli.StringSliceFlag{Name: "header, H", Usage: "Optional
headers. Format: 'hedaderName'='header value'"},
+ cli.BoolFlag{Name: skipSslChecksParam, Usage: "Skip SSL
Checks"},
+ cli.StringFlag{Name: authorizationParam+", A", Usage:
"Type of authentication header. Format: 'authorization=Basic'" +
+ " or
'authorization=Bearer:xxxxx.yyyyyy.zzzzz'"},
Review comment:
rather than `xxxxxx.yyyyy.zzzzz` use `<JWT-token>`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
