geomacy commented on a change in pull request #77: Allow sent user defined 
headers and omit credentials if not needed
URL: https://github.com/apache/brooklyn-client/pull/77#discussion_r287617030
 
 

 ##########
 File path: cli/io/testConfigHeaders.json
 ##########
 @@ -0,0 +1,14 @@
+{
+  "credentials": {
+    "http://some.site:8081": "Og=="
+  },
+  "credentialsRequired": false,
+  "headers": {
 
 Review comment:
   this won't support multiple Brooklyn URLs - the `credentials` field is a map 
of site URL to credentials, if you have multiple sites you will have multiple 
possible combinations of headers, e.g. one site may use regular Basic auth and 
one Oauth. Whatever we come up with must be able to cope with that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to